FaceDetection: use generateUrl for image preview#282
Merged
marcelklehr merged 1 commit intonextcloud:masterfrom Aug 13, 2022
bonswouar:fix/face-detection-preview
Merged
FaceDetection: use generateUrl for image preview#282marcelklehr merged 1 commit intonextcloud:masterfrom bonswouar:fix/face-detection-preview
marcelklehr merged 1 commit intonextcloud:masterfrom
bonswouar:fix/face-detection-preview
Conversation
Member
|
Ahh, thanks! I always forget about this potential problem. In the long term the face overview will be moved to the photos app. (see nextcloud/photos#1155 which uses #270 to access the data). |
Member
|
Ah, pulled to the wrong branch. Manually cherrypicked to stable2, now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #280
I didn't test the exact scenario, and I don't know much about VueJS, but that seems to make sense ;)